#1025 closed defect (fixed)

Fix bashism in fw_conntrack

Reported by: blueyed Owned by: nobody
Priority: normal Milestone: Munin 1.4.6
Component: plugins Version: 1.4.5
Severity: normal Keywords:
Cc:

Description

I am getting notifications like the following:

Connections through firewall
	CRITICALs: Total is 870.76 (outside range [:5]).

This is caused by a bashism in fw_conntrack, where read MAX < $FILE is used.

This reads the first char only, when using dash (as /bin/sh).

The attached patch fixes this, replacing it with "MAX=$(cat $FILE)".

Attachments (1)

munin-fw_conntrack.diff (645 bytes) - added by blueyed at 2011-01-26T23:11:58+01:00.
Proposed patch

Download all attachments as: .zip

Change History (3)

Changed at 2011-01-26T23:11:58+01:00 by blueyed

Proposed patch

comment:1 Changed at 2011-01-26T23:19:22+01:00 by blueyed

This has been reported and worked around in Debian (by using bash).
See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594695#24 for an explanation.

It's not a bashism, but related to reading single bytes from the proc interface.

I think it makes a lot of sense for munin to fix this, either by using cat+fork (preferred IMHO), or bash.

comment:2 Changed at 2011-03-01T00:27:09+01:00 by bldewolf

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r4140 and r4141 (trunk and 1.4-stable).

Note: See TracTickets for help on using tickets.