#1063 closed patch (fixed)

SSH transport should support port number

Reported by: Tenzer Owned by: snide
Priority: normal Milestone: Munin 2.0.0
Component: master Version: devel
Severity: normal Keywords:
Cc:

Description

Here's a pretty trivial patch for adding the port number to the new SSH transport feature. The patch should apply cleanly against both 2.0 alpha2 and trunk.

This allows you to specify the port number for nodes connected with SSH in the format:

address ssh://munin-node-user@host.example.com:2222/path/to/munin-async-client --spoolfetch

When no port number is specified, it will default to port 22, due to the URI module setting that as default when no port number is mentioned in the URI.

Note that with this patch, it is no possible to specify the port number of remote hosts in ssh_config(5), since the '-p' parameter is used to ssh(1), which overrules any settings specified in ssh_config(5).
Since the URI module defaults to port 22, I couldn't find a way to work around this, since I can't know if the port number is specified through munin.conf, or it's just the default.

Attachments (1)

port.diff (468 bytes) - added by Tenzer at 2011-04-06T19:18:17+02:00.

Download all attachments as: .zip

Change History (3)

Changed at 2011-04-06T19:18:17+02:00 by Tenzer

comment:1 Changed at 2011-04-07T13:15:58+02:00 by snide

  • Owner changed from nobody to snide
  • Status changed from new to assigned

comment:2 Changed at 2011-04-07T13:16:48+02:00 by snide

  • Resolution set to fixed
  • Status changed from assigned to closed

Applied on trunk in r4153.

Thx.

Note: See TracTickets for help on using tickets.