Opened 3 years ago

Closed 18 months ago

#1133 closed patch (fixed)

Update to http_loadtime

Reported by: caluml Owned by: nobody
Priority: normal Milestone: Munin 2.2
Component: plugins Version: 1.4.5
Severity: normal Keywords:
Cc:

Description

I believe this patch makes it simpler, as it doesn't involve writing files.
We have had issues in our environments whereby the temp files don't get removed.
I'm not sure why, but it seems unnecessary to write them at all.

--- http_loadtime.orig 2011-09-06 14:27:46.000000000 +0100
+++ http_loadtime 2011-09-06 14:29:16.000000000 +0100
@@ -64,7 +64,7 @@

cd $TMPDIR
exit 1

target="http://$TAR"

-loadtime=$($time_bin -p $wget_bin -p --no-cache --delete-after $target -q 2>&1 | awk '/real / { print $2 }')
+loadtime=$(($time_bin -p $wget_bin -O /dev/null -o /dev/null $target) 2>&1 | awk '/real / { print $2 }')

cd ..

echo "$TAR.value $loadtime"

Change History (2)

comment:1 Changed 3 years ago by caluml

That looks horrible. This should look better.

--- http_loadtime.orig  2011-09-06 14:27:46.000000000 +0100
+++ http_loadtime       2011-09-06 14:29:16.000000000 +0100
@@ -64,7 +64,7 @@

 cd $TMPDIR || exit 1
 target="http://$TAR"
-loadtime=$($time_bin -p $wget_bin -p --no-cache --delete-after $target -q 2>&1 | awk '/^real / { print $2 }')
+loadtime=$(($time_bin -p $wget_bin -O /dev/null -o /dev/null $target) 2>&1 |  awk '/^real / { print $2 }')
 cd ..

 echo "$TAR.value $loadtime"

comment:2 Changed 18 months ago by snide

  • Milestone changed from Munin 1.4.7 to Munin 2.1
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.