Opened 16 months ago

Closed 4 months ago

Last modified 4 months ago

#1196 closed enhancement (fixed)

Munin::Plugin::Pgsql only supports a single postgres installation per host

Reported by: gilesw Owned by: nobody
Priority: normal Milestone: Munin 2.1.0
Component: plugins Version: 1.4.6
Severity: normal Keywords:
Cc:

Description

In order to pass in different ports .etc you need to have a unique config file. Adding a instance id to each plugin symlink allows you to support this. One line change in sub wildcard_parameter.

if ($0 =~ /$self->{basename}instance\d+_(.*)$/ or $0 =~ /$self->{basename}(.*)$/) {

e.g /etc/munin/plugins/postgres_cache_instance1_ALL

reads

/etc/munin/plugin-conf.d/postgres_cache_instance1_ALL

Attachments (1)

postgresql_cache.patch (723 bytes) - added by gael 4 months ago.

Download all attachments as: .zip

Change History (5)

Changed 4 months ago by gael

comment:1 Changed 4 months ago by gael

I made a change postgres_cache_instance1_ALL -> postgres_instance1_cache_ALL
It provides possibility to configure several instances simply

  [postgres_instance1_*]
  ...

I added a draft of the patch.

If this operation is ok I implement on other plugins postgres_ *

Last edited 4 months ago by gael (previous) (diff)

comment:2 Changed 4 months ago by gael

Fixed by https://github.com/munin-monitoring/munin/commit/e1fde80c6f34f2e3be573b5f9576ad4fba25f0ba

Allow you to have :

[postgres_instance1_*]
env.PGPORT 5432

And just add link like that :

/etc/munin/plugins/postgres_instance1_cache_ALL

comment:3 Changed 4 months ago by snide

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 months ago by snide

  • Milestone changed from Munin 2.0 to Munin 2.1
Note: See TracTickets for help on using tickets.