Comparison HTML templates duplicates group names in links when using nested groups

[ssm]

When using two levels of nested groups, the day/week/month/year comparison pages contain links with duplicate group names.

Example:

In a page generated for ​http://munin.example.org/FirstLevel/Secondlevel/comparison-day.html, the second group level "Secondlevel" is also included in the links, resulting in the URI ​http://munin.example.org/FirstLevel/Secondlevel/Secondlevel/mail.example.org/df.html

Example HTML fragment included:

            <td valign="top">
			<table class="invisiblebox">
			  <tr><td colspan="2"></td></tr>
			  <tr><td colspan="2"><div class="lighttext"><a href="mail.example.org/index.html">mail.example.org</a> :: <a  href="Secondlevel/mail.example.org/df.html">Filesystem usage (in %)</a></div></td></tr>

			  <tr><td>
			<a title="Filesystem usage (in %)"/><a href="Secondlevel/mail.example.org/df.html"><img src="./mail.example.org/df-day.png" alt="Filesystem usage (in %)" width="495"  height="292"/></a>
			</td></tr>
			</table>
			</td>

Some debugging indicates that this link ("URL1" in the template) is generated in get_group_tree in master/lib/Munin/Master/HTMLOld.pm, most likely at or around line 730:

    if ($ret->{'url'} ne "/index.html") {
        for (
            my $shrinkpath = $ret->{'url'}, my $counter = 0;
            $shrinkpath =~ /\//;
            $shrinkpath =~ s/^[^\/]+\/*//, $counter++
            ) {
            $ret->{'url' . $counter} = $shrinkpath;
        }
    }

I suspect that changing this to fix the comparison template may cause broken links elsewhere, and it also looks like it is hard to test...

[janl]

This is trickier to fix than you would know. Will atempt to enlist help. Not in 1.4.1 I think.

[janl]

We need to refactor munin-html to be able to solve this I think. The current munin-html data-structure is very very overloaded and abused IMHO.

[snide]

Pushing to 2.1