Ticket #868 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

munin-node-configure --debug bombs on tomcat_ plugin

Reported by: janl Assigned to: ligne
Priority: high Milestone:
Component: node Version: 1.2.6
Severity: normal Keywords:
Cc:

Description (Last modified by janl)

Hi,

Got this on IRC: 

# munin-node-configure --debug --shell
...
DEBUG: Checking plugin: tomcat_...auto...autoconf...suggest...yes:no...Can't use string ("") as an ARRAY ref while "strict refs" in use at /usr/sbin/munin-node-configure line 603.

More was expected after that.

Nicolai

Attachments

munin-bug-868.patch (339 bytes) - added by ligne on 03/10/10 15:55:09.
a hacky fix

Change History

02/19/10 08:22:08 changed by janl

  • description changed.

02/19/10 08:23:38 changed by janl

  • description changed.
  • summary changed from munin-node-configure --debug bombs on tomcat_ plugins to munin-node-configure --debug bombs on tomcat_ plugin.

02/24/10 15:40:44 changed by knan

Looks like 1.2.x munin-node-configure talking. 1.4.x doesn't have that sort of debug output here... 

# Considering '/scratch/munin-svn/sandbox/opt/munin/lib/plugins/tomcat_'
#       Reading magic markers.
#       Set family to 'auto'.
#       Capabilities are: autoconf suggest

03/10/10 15:55:09 changed by ligne

  • attachment munin-bug-868.patch added.

a hacky fix

03/10/10 16:02:46 changed by ligne

  • version changed from 1.4.3 to 1.2.6.

it's definitely 1.2/1.3-era Munin.

i can't seem to reproduce this with 1.2.6, but i can see where the error is occurring ($ps->{$plug}->{'suggest'} is getting set to somewhere along the line), but i can't for the life of me see where that might be.

the patch i just added might act as a workaround. it just makes sure that the key is empty before querying the plugin for suggestions. this shouldn't cause any regressions, since anything in there will be blatted anyway.

sound good?

03/17/10 15:27:58 changed by ligne

  • status changed from new to closed.
  • resolution set to fixed.

no complaints, so resolving fixed.